PR #25: Address TODO: exclude “xml” PI target per XML spec in HTML Tag Processor
We are excited to announce the latest update in our ongoing efforts to enhance “The Flight Log,” specifically with PR #25. This pull request addresses a notable issue within the HTML Tag Processor by excluding the “processing instruction (PI)” as per the XML 1.1 specification. Previously, our processor misclassified XML declarations as COMMENT_AS_PI_NODE_LOOKALIKE, which contradicted the standards outlined in the XML spec.
The core of this update lies within the class-wp-html-tag-processor.php file. We have implemented a check to ensure that if the target is exactly xml (case-insensitive, length 3), the processor will correctly handle it as COMMENT_AS_INVALID_HTML. This resolves the lingering @todo comment previously noted in the code, and we’ve added an explanatory comment referencing the relevant XML spec grammar for future clarity.
In addition to the code adjustments, we’ve bolstered our testing coverage in wpHtmlProcessorComments.php. This includes tests for various case permutations of the XML declaration. For instance, <?xml, <?XML, and <?Xml will now be classified as COMMENT_AS_INVALID_HTML, while <?xml version="1.0"?> remains classified as COMMENT_AS_PI_NODE_LOOKALIKE. We also took the opportunity to correct a typo in our test labels, enhancing the overall quality of our codebase.
As we continue to refine “The Flight Log,” we appreciate the ongoing contributions from our community. This update not only aligns with XML standards but also strengthens the robustness of our HTML processing capabilities, ensuring a smoother experience for all users. We look forward to your feedback on this enhancement!